Fixed available generic args for default impls, and lowering diagnostics of trait fn bodies. #7045
Conversation
|
This change is |
orizi
force-pushed
the
spr/main/c29f1286
branch
2 times, most recently
from
cbf018c to
b0af8ca
Compare
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
tests/bug_samples/issue7038.cairo line 6 at r1 (raw file):
) { func::call(f, ()); f();
don't you need copy for this?
orizi
force-pushed
the
spr/main/c29f1286
branch
from
b0af8ca to
54953d7
Compare
orizi
changed the title
orizi
force-pushed
the
spr/main/c29f1286
branch
from
54953d7 to
5b3d263
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @TomerStarkware)
tests/bug_samples/issue7038.cairo line 6 at r1 (raw file):
Previously, TomerStarkware wrote…
don't you need copy for this?
Done.
orizi
force-pushed
the
spr/main/c29f1286
branch
4 times, most recently
from
e6e6194 to
0f7151e
Compare
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
orizi
force-pushed
the
spr/main/c29f1286
branch
from
0f7151e to
bb9564b
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
Fixes #7031
Fixes #7038